[webkit-reviews] review requested: [Bug 205527] REGRESSION (r212693): getClientRects(), getBoundingClientRect() for range that spans multi-lines differs depending on whether text is selected : [Attachment 386356] Patch and Mac-specific test

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 205527: REGRESSION (r212693): getClientRects(), getBoundingClientRect() for
range that spans multi-lines differs depending on whether text is selected
https://bugs.webkit.org/show_bug.cgi?id=205527

Attachment 386356: Patch and Mac-specific test

https://bugs.webkit.org/attachment.cgi?id=386356&action=review




--- Comment #8 from Daniel Bates <dbates at webkit.org> ---
Created attachment 386356

  --> https://bugs.webkit.org/attachment.cgi?id=386356&action=review

Patch and Mac-specific test

For now add a Mac-specific test. I will look to come up with a more general
purpose test. One way to do this is to use the Ahem font, but it is a bit
tricky as I need to figure out the right Web API to ensure that test waits
until it has loaded. The Mac-specific test is still useful because this same
test can be used for bug #205563. Using Ahem actually masks bug #205563 because
Ahem glyphs are too square that it does not allow testing of line layout
rouding. Right now, I see a future of having both an Ahem-based version of this
test and a Mac-specific one. Maybe drawing borders around the client/border
rects could be a way to write a 100% platform-independent, text-metric agnostic
test. I will think about it.