[webkit-reviews] review granted: [Bug 205543] Very basic <dialog> show/close support : [Attachment 386302] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 205543: Very basic <dialog> show/close support
https://bugs.webkit.org/show_bug.cgi?id=205543

Attachment 386302: Patch

https://bugs.webkit.org/attachment.cgi?id=386302&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 386302
  --> https://bugs.webkit.org/attachment.cgi?id=386302
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386302&action=review

> Source/WebCore/style/UserAgentStyle.cpp:237
> +	   else if (is<HTMLDialogElement>(element) &&
RuntimeEnabledFeatures::sharedFeatures().dialogElementEnabled()) {
> +	       if (!dialogStyleSheet) {
> +		   dialogStyleSheet = parseUASheet(dialogUserAgentStyleSheet,
sizeof(dialogUserAgentStyleSheet));
> +		   addToDefaultStyle(*dialogStyleSheet);
> +	       }
> +	   }

We should remember to merge this to the main stylesheet when this ships.

> Source/WebKit/Shared/WebPreferences.yaml:1889
> +    category: internal

Don't web facing things usually go to experimental?