[webkit-reviews] review granted: [Bug 203643] Web Inspector: Gradient editor: opacity slider is too close to the right edge of the popover : [Attachment 386185] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 203643: Web Inspector: Gradient editor: opacity slider is too close to the
right edge of the popover
https://bugs.webkit.org/show_bug.cgi?id=203643

Attachment 386185: Patch

https://bugs.webkit.org/attachment.cgi?id=386185&action=review




--- Comment #8 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 386185
  --> https://bugs.webkit.org/attachment.cgi?id=386185
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386185&action=review

r=me, with one additional change

> Source/WebInspectorUI/UserInterface/Views/Slider.css:-34
> -    left: -5px;

This doesn't look very good in RTL.  The slider thumb is on the wrong side of
the slider (it's on the right side in LTR and in RTL, whereas it should be on
the left side in RTL).
```
    body[dir=ltr] .slider > img {
	left: 2px;
	transform: translateY(var(--translate-y, 0px)) rotate(270deg);
    }

    body[dir=rtl] .slider > img {
	left: -6px;
	transform: translateY(var(--translate-y, 0px)) rotate(90deg);
    }
```