[webkit-reviews] review granted: [Bug 202064] Flaky crash in AudioSourceProviderAVFObjC::~AudioSourceProviderAVFObjC on webaudio/silent-audio-interrupted-in-background.html : [Attachment 386263] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 202064: Flaky crash in
AudioSourceProviderAVFObjC::~AudioSourceProviderAVFObjC on
webaudio/silent-audio-interrupted-in-background.html
https://bugs.webkit.org/show_bug.cgi?id=202064

Attachment 386263: Patch

https://bugs.webkit.org/attachment.cgi?id=386263&action=review




--- Comment #10 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 386263
  --> https://bugs.webkit.org/attachment.cgi?id=386263
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386263&action=review

The fix looks right to me, TestExpectations need a bit more polish.

> LayoutTests/platform/mac-wk2/TestExpectations:-679
> -webkit.org/b/172201 webaudio/silent-audio-interrupted-in-background.html [
Pass Timeout ]

This is not the [ Pass Crash ] expectation that Truitt added in
https://trac.webkit.org/changeset/253836/webkit