[webkit-reviews] review granted: [Bug 205318] Paint highlights specified in CSS Highlight API : [Attachment 386270] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 205318: Paint highlights specified in CSS Highlight API
https://bugs.webkit.org/show_bug.cgi?id=205318

Attachment 386270: Patch

https://bugs.webkit.org/attachment.cgi?id=386270&action=review




--- Comment #29 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 386270
  --> https://bugs.webkit.org/attachment.cgi?id=386270
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386270&action=review

> Source/WebCore/dom/Document.cpp:784
> +    if (m_highlightMap)
> +	   m_highlightMap->clear();

Nice!

> Source/WebCore/rendering/InlineTextBox.cpp:805
> +    case MarkedText::Highlight: {
> +	   if (auto renderStyle = parent()->renderer().getUncachedPseudoStyle({
PseudoId::Highlight, markedText.highlightName },
&parent()->renderer().style())) {

Now that you've wrapped the whole thing, the outer { ~ } is unnecessary.

> Source/WebCore/rendering/SelectionRangeData.cpp:165
> +    // FIXME: we shouldln't have to check that a renderer is a descendant of
the render node from the range. This is likely because we aren't using
VisiblePositions yet. Planned fix in a followup: <rdar://problem/58095923>

Please split this comment into two lines since it's really long.
And also file a Bugzilla bug & prefer to that instead.
People in the open source community won't be able to follow this otherwise.

> LayoutTests/imported/w3c/ChangeLog:7
> +

Please state from where thees tests are imported, and as of which Git hash.