[webkit-reviews] review denied: [Bug 205413] IndexedDB: delete index records with ID and IndexKey instead of value in SQLiteIDBackingStore : [Attachment 386153] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Sihui Liu
<sihui_liu at apple.com>'s request for review:
Bug 205413: IndexedDB: delete index records with ID and IndexKey instead of
value in SQLiteIDBackingStore
https://bugs.webkit.org/show_bug.cgi?id=205413

Attachment 386153: Patch

https://bugs.webkit.org/attachment.cgi?id=386153&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 386153
  --> https://bugs.webkit.org/attachment.cgi?id=386153
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386153&action=review

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1546
> +	   sql->getColumnBlobAsVector(1, valueBuffer);

Could you make getColumnBlobAsVector return a Vector<uint8_t> and make a
getColumnBlobAsCharVector that returns a Vector<char>?

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1601
> +		   indexKeys.append(indexKey.asOneKey());

Could you write this so that if there's one key, we don't need to allocate a
Vector?  That would probably just move the isValid() check into
deleteOneIndexRecord