[webkit-reviews] review granted: [Bug 205517] Make JSString values from literals in a single consistent style : [Attachment 386248] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 20 14:02:50 PST 2019


Saam Barati <sbarati at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 205517: Make JSString values from literals in a single consistent style
https://bugs.webkit.org/show_bug.cgi?id=205517

Attachment 386248: Patch

https://bugs.webkit.org/attachment.cgi?id=386248&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 386248
  --> https://bugs.webkit.org/attachment.cgi?id=386248
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386248&action=review

> Source/JavaScriptCore/ChangeLog:15
> +	       jsNontrivialString(vm, "literal")

Could we use literal string as template to turn this code into what you did?


More information about the webkit-reviews mailing list