[webkit-reviews] review granted: [Bug 205516] [Bindings] Add @@toStringTag to our iterator prototype object : [Attachment 386245] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 205516: [Bindings] Add @@toStringTag to our iterator prototype object
https://bugs.webkit.org/show_bug.cgi?id=205516

Attachment 386245: Patch

https://bugs.webkit.org/attachment.cgi?id=386245&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 386245
  --> https://bugs.webkit.org/attachment.cgi?id=386245
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386245&action=review

> Source/WebCore/bindings/js/JSDOMIterator.h:267
> +    putDirectWithoutTransition(vm, vm.propertyNames->toStringTagSymbol,
jsString(vm, info()->className), PropertyAttribute::DontEnum |
PropertyAttribute::ReadOnly);

I guess this is the same pattern that prototypes in the JavaScript runtime
follow, so I guess it’s appropriately efficient.

Do we want to expose the actual values from className? No need to be indirect
or hide that as an implementation detail?