[webkit-reviews] review granted: [Bug 205460] Update TrackBase to store m_mediaElement as a WeakPtr : [Attachment 386231] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 20 11:36:13 PST 2019
Jer Noble <jer.noble at apple.com> has granted Doug Kelly <dougk at apple.com>'s
request for review:
Bug 205460: Update TrackBase to store m_mediaElement as a WeakPtr
https://bugs.webkit.org/show_bug.cgi?id=205460
Attachment 386231: Patch
https://bugs.webkit.org/attachment.cgi?id=386231&action=review
--- Comment #9 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 386231
--> https://bugs.webkit.org/attachment.cgi?id=386231
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=386231&action=review
r=me with a lone nit
> Source/WebCore/html/track/TrackListBase.cpp:44
> , m_element(element)
This could be a WTFMove();
More information about the webkit-reviews
mailing list