[webkit-reviews] review denied: [Bug 205407] Create a mechanism for 'safe by default' web views : [Attachment 386139] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has denied katherine_cheney at apple.com's request
for review:
Bug 205407: Create a mechanism for 'safe by default' web views
https://bugs.webkit.org/show_bug.cgi?id=205407

Attachment 386139: Patch

https://bugs.webkit.org/attachment.cgi?id=386139&action=review




--- Comment #4 from Andy Estes <aestes at apple.com> ---
Comment on attachment 386139
  --> https://bugs.webkit.org/attachment.cgi?id=386139
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386139&action=review

I'd like to see this patch make use of this new enum in some way and then have
an API test.

Can you also add a _WKWebViewCategory-typed property to WKWebViewConfiguration,
decide what the default value will be for clients that do not explicitly set a
value, and then write an API test?

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:43
> +    _WKWebViewCategoryWebBrowser,
> +    _WKWebViewCategoryInAppBrowser,
> +    _WKWebViewCategoryHybridApp,

I'd sort these.