[webkit-reviews] review granted: [Bug 205475] Web Inspector: convert some InspectorFrontendHost methods to getters : [Attachment 386161] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 19 16:09:24 PST 2019


Devin Rousso <drousso at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 205475: Web Inspector: convert some InspectorFrontendHost methods to
getters
https://bugs.webkit.org/show_bug.cgi?id=205475

Attachment 386161: Patch

https://bugs.webkit.org/attachment.cgi?id=386161&action=review




--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 386161
  --> https://bugs.webkit.org/attachment.cgi?id=386161
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386161&action=review

r=me once EWS is happy :)

> Source/WebCore/inspector/InspectorFrontendHost.h:85
>      String port();

Shouldn't this also be `const`?

> Source/WebCore/inspector/InspectorFrontendHost.h:89
> +    String platform() const;

NIT: why not put this next to `port`?


More information about the webkit-reviews mailing list