[webkit-reviews] review denied: [Bug 204407] [css-grid] Move some alignment tests to the WPT folder : [Attachment 386098] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has denied rmonteriso at igalia.com's
request for review:
Bug 204407: [css-grid] Move some alignment tests to the WPT folder
https://bugs.webkit.org/show_bug.cgi?id=204407

Attachment 386098: Patch

https://bugs.webkit.org/attachment.cgi?id=386098&action=review




--- Comment #9 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 386098
  --> https://bugs.webkit.org/attachment.cgi?id=386098
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386098&action=review

> LayoutTests/ChangeLog:8
> +	   Remove some tests from fast/css-grid/alignment, that are being
replaced by adapted tests in the corresponding Wpt test folder

Nit: s/Wpt/WPT/
Nit: Add a dot at the end of the sentence.

> LayoutTests/imported/w3c/ChangeLog:8
> +	   Add some css alignment tests from WebKit, checked and adapted to
Wpt, in the corresponding css-grid/alignment folder.

Nit: s/Wpt/WPT/.

> LayoutTests/imported/w3c/ChangeLog:11
> +	   * web-platform-tests/css/css-grid/alignment/grid-align-content.html:

You miss the new -expected.txt results for all these tests.