[webkit-reviews] review granted: [Bug 205417] Resync web-platform-tests/beacon tests from upstream : [Attachment 386108] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 205417: Resync web-platform-tests/beacon tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=205417

Attachment 386108: Patch

https://bugs.webkit.org/attachment.cgi?id=386108&action=review




--- Comment #7 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 386108
  --> https://bugs.webkit.org/attachment.cgi?id=386108
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386108&action=review

>> Tools/Scripts/webkitpy/w3c/test_converter.py:53
>> +	contents = contents.replace('{{domains[www]}}', '{{hosts[alt][]}}')
> 
> I updated our import script to replace {{domains[www]}} with {{hosts[alt][]}}
automatically.

We should probably add a unit test for this in
Tools/Scripts/webkitpy/w3c/test_converter_unittest.py.
Some tests will still not be converted properly as they might be using things
like 'www' + location.host, but this seems convenient and will fix many tests I
believe.

I think we should still work on fixing these tests upstream instead of relying
on this conversion.
Note also that this conversion is wrong in a few cases since some tests
actually require www.localhost instead of 127.0.0.1.
We probably do not care since we do not have the infra to run these tests in
WebKit CI.

> Tools/Scripts/webkitpy/w3c/test_importer.py:449
> +	   folders_needing_file_rewriting = ['web-platform-tests/', ]

Could remove the ', '