[webkit-reviews] review granted: [Bug 205382] [GStreamer][EME] Notify all elements waiting for CDM attachment : [Attachment 385978] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 19 03:26:06 PST 2019


Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Charlie Turner
<cturner at igalia.com>'s request for review:
Bug 205382: [GStreamer][EME] Notify all elements waiting for CDM attachment
https://bugs.webkit.org/show_bug.cgi?id=205382

Attachment 385978: Patch

https://bugs.webkit.org/attachment.cgi?id=385978&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 385978
  --> https://bugs.webkit.org/attachment.cgi?id=385978
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385978&action=review

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1794
> +	   auto cdmAttachmentLocker = holdLock(m_cdmAttachmentMutex);
> +	   bool didCDMAttach =
m_cdmAttachmentCondition.waitFor(m_cdmAttachmentMutex, 4_s, [this]() {
> +	       return isCDMAttached();
> +	   });
> +	   cdmAttachmentLocker.unlockEarly();

I would prefer to take the boolean definition outside and open a nested scope
to avoid unlocking early. I think it is less future error prone.

>
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.c
pp:768
> +	   else
> +	       result = MediaPlayer::SupportsType::IsNotSupported;

As a personal preference I would move this upfront and avoid the else.

Anyway, this seems to be quite unrelated and I would recommend to land it in a
another no-brainer bug.


More information about the webkit-reviews mailing list