[webkit-reviews] review granted: [Bug 205417] Resync web-platform-tests/beacon tests from upstream : [Attachment 386010] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 19 00:41:03 PST 2019


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 205417: Resync web-platform-tests/beacon tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=205417

Attachment 386010: Patch

https://bugs.webkit.org/attachment.cgi?id=386010&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 386010
  --> https://bugs.webkit.org/attachment.cgi?id=386010
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386010&action=review

>
LayoutTests/imported/w3c/web-platform-tests/beacon/beacon-cors.sub.window-expec
ted.txt:21
> +Blocked access to external URL
http://www.localhost:8800/beacon/resources/beacon.py?cmd=store&sid=5edb8afd-19c
1-44c8-861c-546f9537bcca&tid=SmallCORSContentTypeText-PREFLIGHT-ALLOW&tidx=0&or
igin=http://localhost:8800&credentials=true&preflightExpected=true

We should skip this test for now since it is using www.localhost.
We should then modify the test to replace domains[www] by {hosts[alt][]} so as
to use 127.0.0.1 in our CI instead of www.localhost.


More information about the webkit-reviews mailing list