[webkit-reviews] review granted: [Bug 205429] macCatalyst: Cursor should update when the platform deems it necessary : [Attachment 386044] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 205429: macCatalyst: Cursor should update when the platform deems it
necessary
https://bugs.webkit.org/show_bug.cgi?id=205429

Attachment 386044: Patch

https://bugs.webkit.org/attachment.cgi?id=386044&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 386044
  --> https://bugs.webkit.org/attachment.cgi?id=386044
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386044&action=review

> Source/WebKit/Shared/ios/InteractionInformationAtPosition.h:87
> +    float caretHeight;

Nit - maybe give this an initial value?

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2766
> +    if (Frame* frame = hitTestResult.innerNodeFrame()) {
> +	   if (FrameView *frameView = frame->view()) {

Nit - auto*?