[webkit-reviews] review granted: [Bug 205419] IPC::Connection::sendMessage() should use CRASH_WITH_INFO() : [Attachment 386018] Patch v2

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 205419: IPC::Connection::sendMessage() should use CRASH_WITH_INFO()
https://bugs.webkit.org/show_bug.cgi?id=205419

Attachment 386018: Patch v2

https://bugs.webkit.org/attachment.cgi?id=386018&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 386018
  --> https://bugs.webkit.org/attachment.cgi?id=386018
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=386018&action=review

> Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm:277
> +	   WebKit::setCrashReportApplicationSpecificInformation((__bridge
CFStringRef)[NSString stringWithFormat:@"Unhandled error code %x, message
'%s'", kr, messageName.data()]);

nit: Might as well log messageName.hash() as well.