[webkit-reviews] review granted: [Bug 204859] Web Inspector: Runtime.enable reports duplicates (non existent) contexts : [Attachment 385512] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 204859: Web Inspector: Runtime.enable reports duplicates (non existent)
contexts
https://bugs.webkit.org/show_bug.cgi?id=204859

Attachment 385512: Patch

https://bugs.webkit.org/attachment.cgi?id=385512&action=review




--- Comment #17 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 385512
  --> https://bugs.webkit.org/attachment.cgi?id=385512
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385512&action=review

r=me

> Source/WebCore/inspector/agents/page/PageRuntimeAgent.cpp:156
> +	       if (scriptState != globalObject)

NIT: I'd flip the order of these, given that `globalObject` is more local than
`scriptState`

>> Source/WebInspectorUI/UserInterface/Models/ExecutionContextList.js:-52
>> -	    }
> 
> It looks like we will still want something like this code for the Remote
Inspector connected to legacy backends that do continue to send duplicates.
> 
> Perhaps keep the code and add:
> 
>     // COMPATIBILITY (iOS 13.0): Older iOS releases will send duplicates.
Newer releases will not.

Ah, yeah!  I totally forgot about that.  Good catch Joe!

>> LayoutTests/http/tests/inspector/resources/stable-id-map.js:35
>> +		this._lastAssignedId = 0;
> 
> This is unused.

NIT: this is no longer used