[webkit-reviews] review granted: [Bug 205281] Only report prevalent domains in the ResourceLoadStatistics data summary API : [Attachment 385840] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted katherine_cheney at apple.com's
request for review:
Bug 205281: Only report prevalent domains in the ResourceLoadStatistics data
summary API
https://bugs.webkit.org/show_bug.cgi?id=205281

Attachment 385840: Patch

https://bugs.webkit.org/attachment.cgi?id=385840&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 385840
  --> https://bugs.webkit.org/attachment.cgi?id=385840
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385840&action=review

>
LayoutTests/http/tests/resourceLoadStatistics/aggregate-sorted-data-no-storage-
access-database-expected.txt:16
> +    isPrevalentResource: Yes

Can you confirm we have some tests that verify things are not prevalent if they
are beneath the thresholds? I think this is true, but have not checked myself.

>
LayoutTests/http/tests/resourceLoadStatistics/count-third-party-script-import-i
n-worker-database-expected.txt:-29
> -Third Party Registrable Domain: localhost

Are these changes because we are no longer returning non-prevelant resources in
the ITP data returned by the new API?