[webkit-reviews] review granted: [Bug 202508] [GTK] WebGL backed by ANGLE flickers when USE_OPENGL_ES is enabled. : [Attachment 384482] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 18 07:17:30 PST 2019


Zan Dobersek <zan at falconsigh.net> has granted ChangSeok Oh
<changseok at webkit.org>'s request for review:
Bug 202508: [GTK] WebGL backed by ANGLE flickers when USE_OPENGL_ES is enabled.
https://bugs.webkit.org/show_bug.cgi?id=202508

Attachment 384482: Patch

https://bugs.webkit.org/attachment.cgi?id=384482&action=review




--- Comment #2 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 384482
  --> https://bugs.webkit.org/attachment.cgi?id=384482
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384482&action=review

> Source/WebCore/platform/graphics/nicosia/texmap/NicosiaGC3DLayer.cpp:115
> -	       auto texture =
BitmapTextureGL::create(TextureMapperContextAttributes::get(),
m_context.m_internalColorFormat);
> +	       auto texture =
BitmapTextureGL::create(TextureMapperContextAttributes::get(), flags,
m_context.m_internalColorFormat);

Ooof, good fix.


More information about the webkit-reviews mailing list