[webkit-reviews] review granted: [Bug 205362] [LFC][IFC] Add lastInlineItemWithContent to LineBreaker::Content::isAtSoftWrapOpportunity : [Attachment 385927] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 205362: [LFC][IFC] Add lastInlineItemWithContent to
LineBreaker::Content::isAtSoftWrapOpportunity
https://bugs.webkit.org/show_bug.cgi?id=205362

Attachment 385927: Patch

https://bugs.webkit.org/attachment.cgi?id=385927&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 385927
  --> https://bugs.webkit.org/attachment.cgi?id=385927
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385927&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp:299
> +	   for (auto i = priorContent.size(); i--;) {
> +	       auto& previousInlineItem = runs[i].inlineItem;

This could uses range for and WTF::makeReversedRange

> Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp:304
> +	       ASSERT_NOT_REACHED();

I still prefer for loops looping over the main body.