[webkit-reviews] review granted: [Bug 205342] Re-sync web-platform-tests/common from upstream : [Attachment 385935] Patch

[bugzilla-daemon at webkit.org]

Frédéric Wang (:fredw) <fred.wang at free.fr> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 205342: Re-sync web-platform-tests/common from upstream
https://bugs.webkit.org/show_bug.cgi?id=205342

Attachment 385935: Patch

https://bugs.webkit.org/attachment.cgi?id=385935&action=review




--- Comment #6 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 385935
  --> https://bugs.webkit.org/attachment.cgi?id=385935
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385935&action=review

> LayoutTests/canvas/philip/tests/2d.drawImage.incomplete.emptysrc.html:7
> +<link rel="stylesheet"
href="../../../imported/w3c/web-platform-tests/2dcontext/resources/canvas-tests
.css">

I noticed that these tests currently rely on imported/w3c/web-platform-tests
resources. Although your patch does not change the situation, I think there has
been some controversy in the past when relying on WPT (bug 179769) so it might
be worth checking with your colleagues.