[webkit-reviews] review granted: [Bug 205236] [iOS] The WebContent process should not use API to get the user interface idiom : [Attachment 385696] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 17 16:27:09 PST 2019


Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 205236: [iOS] The WebContent process should not use API to get the user
interface idiom
https://bugs.webkit.org/show_bug.cgi?id=205236

Attachment 385696: Patch

https://bugs.webkit.org/attachment.cgi?id=385696&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 385696
  --> https://bugs.webkit.org/attachment.cgi?id=385696
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385696&action=review

r=me

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2929
> +	       return !WebKit::currentUserInterfaceIdiomIsPad();

Incorrect indentation.


More information about the webkit-reviews mailing list