[webkit-reviews] review granted: [Bug 205282] Missing tests on r253521 : [Attachment 385920] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 17 14:30:59 PST 2019


zalan <zalan at apple.com> has granted Sunny He <sunny_he at apple.com>'s request for
review:
Bug 205282: Missing tests on r253521
https://bugs.webkit.org/show_bug.cgi?id=205282

Attachment 385920: Patch

https://bugs.webkit.org/attachment.cgi?id=385920&action=review




--- Comment #17 from zalan <zalan at apple.com> ---
Comment on attachment 385920
  --> https://bugs.webkit.org/attachment.cgi?id=385920
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385920&action=review

> Source/WebCore/rendering/svg/SVGRenderSupport.cpp:79
> +	   return FloatRect();

I think { } is more appropriate here (nullopt vs. empty rect)


More information about the webkit-reviews mailing list