[webkit-reviews] review granted: [Bug 204927] Fix WebGL conformance test build_177_to_178.html with USE_ANGLE : [Attachment 384973] Don't disable extension for compileShaderDirect

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 17 13:27:55 PST 2019


Dean Jackson <dino at apple.com> has granted James Darpinian
<jdarpinian at gmail.com>'s request for review:
Bug 204927: Fix WebGL conformance test build_177_to_178.html with USE_ANGLE
https://bugs.webkit.org/show_bug.cgi?id=204927

Attachment 384973: Don't disable extension for compileShaderDirect

https://bugs.webkit.org/attachment.cgi?id=384973&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 384973
  --> https://bugs.webkit.org/attachment.cgi?id=384973
Don't disable extension for compileShaderDirect

View in context: https://bugs.webkit.org/attachment.cgi?id=384973&action=review

> Source/WebCore/platform/graphics/angle/GraphicsContext3DANGLE.cpp:-822
> -    compileShader(shader);

Hopefully this method will go away soon (with an ANGLE backend)


More information about the webkit-reviews mailing list