[webkit-reviews] review denied: [Bug 205239] Refactor ScriptController:evaluateInWorld to support asynchronous operation. : [Attachment 385852] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Brady Eidson
<beidson at apple.com>'s request for review:
Bug 205239: Refactor ScriptController:evaluateInWorld to support asynchronous
operation.
https://bugs.webkit.org/show_bug.cgi?id=205239

Attachment 385852: Patch

https://bugs.webkit.org/attachment.cgi?id=385852&action=review




--- Comment #14 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 385852
  --> https://bugs.webkit.org/attachment.cgi?id=385852
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385852&action=review

I don't think this accomplishes anything.  It just makes a Function that must
be called immediately.	The whole point of Functions is that they don't need to
be called immediately.	Do you have plans to push this asynchrony lower?  If
not, then your intended caller could just take a Function, do the work
synchronously, then call the Function with the result.

> Source/WebCore/bindings/js/ExceptionDetails.h:36
> -    String sourceURL;
> +    String sourceURL { };

This does nothing because String has a default constructor.

> Source/WebCore/bindings/js/ScriptController.h:93
> +    using ResolveFunction = WTF::Function<void(ValueOrException)>;

CompletionHandler?