[webkit-reviews] review granted: [Bug 205323] [JSC] 8Bit JSRopeString can contain 16Bit string in its rope : [Attachment 385850] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 205323: [JSC] 8Bit JSRopeString can contain 16Bit string in its rope
https://bugs.webkit.org/show_bug.cgi?id=205323

Attachment 385850: Patch

https://bugs.webkit.org/attachment.cgi?id=385850&action=review




--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 385850
  --> https://bugs.webkit.org/attachment.cgi?id=385850
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385850&action=review

r=me.  I wish there's a way to assert that we're not copying 16-bit chars that
don't fit into 8-bit chars, but so far, I think that such an assertion is too
expensive to have enabled all the time even for a debug build.	Can you file a
bug to investigate options for testing this?

> Source/JavaScriptCore/runtime/JSString.h:594
>      void resolveRopeSlowCase8(LChar*) const;

I think this function is now deleted in the implementation.  Please remove this
declaration.