[webkit-reviews] review granted: [Bug 205338] WebKitTestRunner should report GPU process crashes : [Attachment 385885] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 17 10:51:32 PST 2019
Tim Horton <thorton at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 205338: WebKitTestRunner should report GPU process crashes
https://bugs.webkit.org/show_bug.cgi?id=205338
Attachment 385885: Patch
https://bugs.webkit.org/attachment.cgi?id=385885&action=review
--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 385885
--> https://bugs.webkit.org/attachment.cgi?id=385885
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=385885&action=review
> Source/WebKit/UIProcess/API/C/WKContext.h:108
> + WKContextChildProcessDidCrashCallback
gpuProcessDidCrash;
> } WKContextClientV3;
Don't you need to bump the struct version? Otherwise folks using V3 will be
missing one zero in their initializers :P
More information about the webkit-reviews
mailing list