[webkit-reviews] review granted: [Bug 205328] Update session category in MockAudioSharedUnit as done in CoreAudioSharedUnit : [Attachment 385865] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 205328: Update session category in MockAudioSharedUnit as done in
CoreAudioSharedUnit
https://bugs.webkit.org/show_bug.cgi?id=205328

Attachment 385865: Patch

https://bugs.webkit.org/attachment.cgi?id=385865&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 385865
  --> https://bugs.webkit.org/attachment.cgi?id=385865
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385865&action=review

> Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp:93
> +bool BaseAudioSharedUnit::startUnit()

This should return OSStatus since the value is returned by prepareForNewCapture
in the event of a failure.