[webkit-reviews] review granted: [Bug 205330] [GTK][WPE] IndexedDB directory set in WebsiteDataManager is ignored : [Attachment 385866] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 205330: [GTK][WPE] IndexedDB directory set in WebsiteDataManager is ignored
https://bugs.webkit.org/show_bug.cgi?id=205330

Attachment 385866: Patch

https://bugs.webkit.org/attachment.cgi?id=385866&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 385866
  --> https://bugs.webkit.org/attachment.cgi?id=385866
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385866&action=review

> Source/WebKit/UIProcess/WebProcessPool.cpp:540
>	   parameters.defaultDataStoreParameters.indexedDatabaseDirectory =
WebKit::WebsiteDataStore::defaultDataStore()->parameters().indexedDatabaseDirec
tory;

LGTM.
There is some pre-existing inconsistencies in this method with
withWebsiteDataStore .
Some other parameters like
parameters.defaultDataStoreParameters.networkSessionParameters.networkCacheDire
ctory also check for withWebsiteDataStore.