[webkit-reviews] review granted: [Bug 205267] WebKitTestRunner should report service worker process crashes : [Attachment 385761] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 205267: WebKitTestRunner should report service worker process crashes
https://bugs.webkit.org/show_bug.cgi?id=205267

Attachment 385761: Patch

https://bugs.webkit.org/attachment.cgi?id=385761&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 385761
  --> https://bugs.webkit.org/attachment.cgi?id=385761
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385761&action=review

> Source/WebKit/UIProcess/API/C/WKContext.h:106
> +    WKContextNetworkProcessDidCrashCallback				  
serviceWorkerProcessDidCrash;

WKContextNetworkProcessDidCrashCallback ->
WKContextChildProcessDidCrashCallback
or introduce a new typedef for the service worker. It is very confusing to have
a Callback with NetworkProcess in there, even though it gets called for the
ServiceWorkerProcess.