[webkit-reviews] review granted: [Bug 205271] lldbwebkittester: Conform with testing binary format : [Attachment 385772] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 205271: lldbwebkittester: Conform with testing binary format
https://bugs.webkit.org/show_bug.cgi?id=205271

Attachment 385772: Patch

https://bugs.webkit.org/attachment.cgi?id=385772&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 385772
  --> https://bugs.webkit.org/attachment.cgi?id=385772
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385772&action=review

> Tools/ChangeLog:8
> +	   lldbwebkittester should be built the same way ImageDiff,
TestWebKitAPI and WebKitTestRunner are.

I think that it would be helpful to elaborate more. In addition to consistency,
this paves the way to testing lldb scripts against WebCore and WebKit in the
future, which would be a non-starter if build-lldbwebkittester was expected to
rebuild everything.

> Tools/ChangeLog:11
> +	   * Scripts/build-webkit:

Does make build it already? build-webkit should be consistent with make too.