[webkit-reviews] review granted: [Bug 205203] TextManipulationController should observe newly inserted or displayed contents : [Attachment 385669] Adds the feature

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 205203: TextManipulationController should observe newly inserted or
displayed contents
https://bugs.webkit.org/show_bug.cgi?id=205203

Attachment 385669: Adds the feature

https://bugs.webkit.org/attachment.cgi?id=385669&action=review




--- Comment #5 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 385669
  --> https://bugs.webkit.org/attachment.cgi?id=385669
Adds the feature

View in context: https://bugs.webkit.org/attachment.cgi?id=385669&action=review

> Source/WebCore/ChangeLog:14
> +	   a newly inserted content, we scheudle a new event loop task to do
this work.

Nit - scheudle

> Source/WebCore/editing/TextManipulationController.cpp:131
> +    if (document != start.deepEquivalent().document() || document !=
end.deepEquivalent().document())

Is it worth keeping the null check for the case where start and end positions
are null?

> Tools/ChangeLog:9
> +	   Added tests for detectign newly inserted or displayed contents in
WKTextManipulation SPI.

Nit - detectign