[webkit-reviews] review granted: [Bug 205067] Remove redundant grid.css files : [Attachment 385756] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 16 06:46:15 PST 2019


Manuel Rego Casasnovas <rego at igalia.com> has granted rmonteriso at igalia.com's
request for review:
Bug 205067: Remove redundant grid.css files
https://bugs.webkit.org/show_bug.cgi?id=205067

Attachment 385756: Patch

https://bugs.webkit.org/attachment.cgi?id=385756&action=review




--- Comment #8 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 385756
  --> https://bugs.webkit.org/attachment.cgi?id=385756
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385756&action=review

This one looks good, thanks.

> LayoutTests/imported/w3c/ChangeLog:8
> +	   Reference all grid tests to a single grid.css inside and remove
redundant grid.css files, inside the single test folders.

Nit: Maybe rename this sentence to something like "Reference all grid tests to
a single grid.css inside css/support/ and remove redundant grid.css files
inside css/css-grid/ subfolders."


More information about the webkit-reviews mailing list