[webkit-reviews] review granted: [Bug 205246] [LFC][IFC] Fix imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-009.html : [Attachment 385709] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 205246: [LFC][IFC] Fix
imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-009.html
https://bugs.webkit.org/show_bug.cgi?id=205246

Attachment 385709: Patch

https://bugs.webkit.org/attachment.cgi?id=385709&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 385709
  --> https://bugs.webkit.org/attachment.cgi?id=385709
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385709&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp:286
> +	       // [ ][ ] : adjacent whitespace content has soft wrap
opportunity.
> +	       if (lastUncomittedContent->isText() &&
downcast<InlineTextItem>(*lastUncomittedContent).isWhitespace())
> +		   isAtSoftWrapOpportunityBeforeWhitespace = true;

break-space might need a new strategy at some point. Creating InlineTextItems
for each space is not very efficient at all.