[webkit-reviews] review granted: [Bug 205015] Navigation from empty page doesn't use cached web process : [Attachment 385698] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Ben Nham <nham at apple.com>'s request
for review:
Bug 205015: Navigation from empty page doesn't use cached web process
https://bugs.webkit.org/show_bug.cgi?id=205015

Attachment 385698: Patch

https://bugs.webkit.org/attachment.cgi?id=385698&action=review




--- Comment #9 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 385698
  --> https://bugs.webkit.org/attachment.cgi?id=385698
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385698&action=review

Looks good.

> Source/WebKit/ChangeLog:15
> +	   Add an API test.

"Added"

> Source/WebKit/UIProcess/WebProcessPool.cpp:2208
> +	       LOG(ProcessSwapping, "(ProcessSwapping) Reusing a previously
cached process with pid %i to continue navigation to URL %s in place of pid %i
that hasn't committed any provisional loads", process->processIdentifier(),
targetURL.string().utf8().data(), sourceProcess->processIdentifier());

I don't mind you adding a LOG() that contains the URL since this is debug only.
However, there should definitely be a RELEASE_LOG() like in the rest of this
function to facilitate debugging in release builds. You also cannot log the URL
or domain in the RELEASE_LOG() though.