[webkit-reviews] review granted: [Bug 205169] SecurityOrigin should be unique for null blob URLs that have been unregistered : [Attachment 385601] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 205169: SecurityOrigin should be unique for null blob URLs that have been
unregistered
https://bugs.webkit.org/show_bug.cgi?id=205169

Attachment 385601: Patch

https://bugs.webkit.org/attachment.cgi?id=385601&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 385601
  --> https://bugs.webkit.org/attachment.cgi?id=385601
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385601&action=review

> Source/WebCore/fileapi/ThreadableBlobRegistry.cpp:166
> +    if (!url.protocolIsBlob() || BlobURL::getOrigin(url) != "null")
> +	   return nullptr;

Seems like the special name "null" should be gotten from calling a function
rather than a hardcoded string constant.