[webkit-reviews] review granted: [Bug 205214] Add an option to run_webkit_tests.py to enable all GPU process related features and choose the additional expectations : [Attachment 385636] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Peng Liu <peng.liu6 at apple.com>'s
request for review:
Bug 205214: Add an option to run_webkit_tests.py to enable all GPU process
related features and choose the additional expectations
https://bugs.webkit.org/show_bug.cgi?id=205214

Attachment 385636: Patch

https://bugs.webkit.org/attachment.cgi?id=385636&action=review




--- Comment #8 from Tim Horton <thorton at apple.com> ---
Comment on attachment 385636
  --> https://bugs.webkit.org/attachment.cgi?id=385636
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385636&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:329
> +	       help=("Enable all GPU process related features. Equivalent to
'--internal-feature=useGPUProcessForMedia
--internal-feature=CaptureAudioInGPUProcessEnabled
--additional-expectations=LayoutTests/gpu-process/TestExpectations'")),

I wonder if we should avoid listing the --internal-features in the help here,
because people are going to change the set, and probably not change this list.
ALSO, you still have a lower-case u in "useGPUProcessForMedia" here.