[webkit-reviews] review granted: [Bug 205211] Add a Heap::finalize function that takes WTF::Function<void()> : [Attachment 385627] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 13 12:13:09 PST 2019


Geoffrey Garen <ggaren at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 205211: Add a Heap::finalize function that takes WTF::Function<void()>
https://bugs.webkit.org/show_bug.cgi?id=205211

Attachment 385627: patch

https://bugs.webkit.org/attachment.cgi?id=385627&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 385627
  --> https://bugs.webkit.org/attachment.cgi?id=385627
patch

r=me

I would prefer to use a separate FinalizerOwner rather than bit masking the
pointer because it would be a little clearer.


More information about the webkit-reviews mailing list