[webkit-reviews] review granted: [Bug 205177] Add MESSAGE_CHECK() for selectedIndex in Messages::WebPageProxy::ShowPopupMenu : [Attachment 385545] Patch v1

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 205177: Add MESSAGE_CHECK() for selectedIndex in
Messages::WebPageProxy::ShowPopupMenu
https://bugs.webkit.org/show_bug.cgi?id=205177

Attachment 385545: Patch v1

https://bugs.webkit.org/attachment.cgi?id=385545&action=review




--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 385545
  --> https://bugs.webkit.org/attachment.cgi?id=385545
Patch v1

Seems to me that if the WebContent process would have sent us a bad index
previously, we would have had a UIProcess crash. Crashing the WebContent
process in this case seems like a much better outcome. If the WebContent
process can sometimes send a bad index without being compromised (e.g. due to a
race), then this should be addressed on WebContent process side. I still think
a MESSAGE_CHECK() is the right thing to do on UIProcess side.