[webkit-reviews] review denied: [Bug 205067] Remove redundant grid.css files : [Attachment 385593] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 13 05:32:35 PST 2019
Manuel Rego Casasnovas <rego at igalia.com> has denied rmonteriso at igalia.com's
request for review:
Bug 205067: Remove redundant grid.css files
https://bugs.webkit.org/show_bug.cgi?id=205067
Attachment 385593: Patch
https://bugs.webkit.org/attachment.cgi?id=385593&action=review
--- Comment #5 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 385593
--> https://bugs.webkit.org/attachment.cgi?id=385593
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=385593&action=review
> LayoutTests/imported/w3c/ChangeLog:4464
> + (#?:
Please avoid this change.
> LayoutTests/imported/w3c/ChangeLog:4472
> + (#?:
Ditto.
> LayoutTests/imported/w3c/ChangeLog:4474
> + (#?:
Ditto.
> LayoutTests/imported/w3c/resources/import-expectations.json:84
> + "web-platform-tests/css/css-grid/grid-definition": "import",
This line is not needed.
Actually just one line would be good enough. It's not a problem that more are
added but we don't need duplicated ones.
You can either remove this one, or remove all the subfolder lines and just keep
the main one like:
"web-platform-tests/css/css-grid": "import",
More information about the webkit-reviews
mailing list