[webkit-reviews] review granted: [Bug 205041] IsLoggedIn: Abstract data type for IsLoggedIn state : [Attachment 385467] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted John Wilander <wilander at apple.com>'s
request for review:
Bug 205041: IsLoggedIn: Abstract data type for IsLoggedIn state
https://bugs.webkit.org/show_bug.cgi?id=205041

Attachment 385467: Patch

https://bugs.webkit.org/attachment.cgi?id=385467&action=review




--- Comment #14 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 385467
  --> https://bugs.webkit.org/attachment.cgi?id=385467
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385467&action=review

> Source/WebCore/page/LoggedInStatus.cpp:62
> +: m_domain { domain }

Indentation problem.

> Source/WebCore/page/LoggedInStatus.h:39
> +class LoggedInStatus : public RefCounted<LoggedInStatus> {

Without seeing how this will be used, it is hard for me to comment on whether
or not this should subclass RefCounted.

> Source/WebCore/page/LoggedInStatus.h:62
> +    using RefCounted::ref;

Why is this needed?

> Source/WebCore/page/LoggedInStatus.h:63
> +    using RefCounted::deref;

Ditto.