[webkit-reviews] review denied: [Bug 205151] Refactor ScriptController's proliferation of ExceptionDetails* : [Attachment 385510] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 12 10:58:53 PST 2019
Sam Weinig <sam at webkit.org> has denied Brady Eidson <beidson at apple.com>'s
request for review:
Bug 205151: Refactor ScriptController's proliferation of ExceptionDetails*
https://bugs.webkit.org/show_bug.cgi?id=205151
Attachment 385510: Patch
https://bugs.webkit.org/attachment.cgi?id=385510&action=review
--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 385510
--> https://bugs.webkit.org/attachment.cgi?id=385510
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=385510&action=review
> Source/WebCore/bindings/js/ScriptController.cpp:115
> +ValueAndException ScriptController::evaluateInWorld(const ScriptSourceCode&
sourceCode, DOMWrapperWorld& world)
It feels like this should return something called ValueOrException (which makes
me wonder if the existing ExceptionOr<> class could be used here), since it
looks like when an exception is thrown, the value is set to { }. If
ExceptionOr<> isn't quite right, adding an ExceptionDetailsOr<> seems ok, or
just using Expected<JSC::JSValue, ExceptionDetails>
More information about the webkit-reviews
mailing list