[webkit-reviews] review granted: [Bug 205170] [LFC][IFC] Fix fast/text/whitespace/023.html : [Attachment 385506] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 205170: [LFC][IFC] Fix fast/text/whitespace/023.html
https://bugs.webkit.org/show_bug.cgi?id=205170

Attachment 385506: Patch

https://bugs.webkit.org/attachment.cgi?id=385506&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 385506
  --> https://bugs.webkit.org/attachment.cgi?id=385506
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385506&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:65
> +    m_collectExpansionOpportunities = textIsAlignJustify && whitespace !=
WhiteSpace::Pre && whitespace != WhiteSpace::PreWrap && whitespace !=
WhiteSpace::BreakSpaces;

Doesn't some combination of whitespace != WhiteSpace::Pre && whitespace !=
WhiteSpace::PreWrap && whitespace != WhiteSpace::BreakSpaces show up in other
places too? Maybe there is or should be a helper?