[webkit-reviews] review granted: [Bug 205144] REGRESSION (r229930, r231063): WebKitLegacy.xcconfig overwrites OTHER_CFLAGS, OTHER_CPLUSPLUSFLAGS and OTHER_LDFLAGS from Base.xcconfig : [Attachment 385458] Patch v1

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 205144: REGRESSION (r229930, r231063): WebKitLegacy.xcconfig overwrites
OTHER_CFLAGS, OTHER_CPLUSPLUSFLAGS and OTHER_LDFLAGS from Base.xcconfig
https://bugs.webkit.org/show_bug.cgi?id=205144

Attachment 385458: Patch v1

https://bugs.webkit.org/attachment.cgi?id=385458&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 385458
  --> https://bugs.webkit.org/attachment.cgi?id=385458
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=385458&action=review

> Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:47
> +OTHER_CFLAGS_COCOA_TOUCH = $(OTHER_CFLAGS_COCOA_TOUCH_$(WK_IS_COCOA_TOUCH));

Is it always YES or NO, or can it be empty? If the latter, then we also need
OTHER_CFLAGS_COCOA_TOUCH_ - which is typical for most variables in xcconfigs.

Your patch doesn't change this aspect, but worth taking the opportunity to
confirm.