[webkit-reviews] review granted: [Bug 205126] IndexedDB: Fix a wrong condition in MemoryIDBBackingStore::deleteIndex : [Attachment 385411] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 12 00:20:02 PST 2019


youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 205126: IndexedDB: Fix a wrong condition in
MemoryIDBBackingStore::deleteIndex
https://bugs.webkit.org/show_bug.cgi?id=205126

Attachment 385411: Patch

https://bugs.webkit.org/attachment.cgi?id=385411&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 385411
  --> https://bugs.webkit.org/attachment.cgi?id=385411
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385411&action=review

> Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp:273
>	   objectStoreInfo->deleteIndex(indexIdentifier);

Is there a way to test this? MemoryObjectStore::deleteIndex has some error
cases but it seems we ASSERT/return early for some of these cases here.


More information about the webkit-reviews mailing list