[webkit-reviews] review granted: [Bug 205148] Web Inspector: REGRESSION(r251227): Uncaught Exception: undefined is not an object (evaluating 'target.DOMAgent.setInspectModeEnabled') : [Attachment 385469] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 11 18:08:25 PST 2019


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 205148: Web Inspector: REGRESSION(r251227): Uncaught Exception: undefined
is not an object (evaluating 'target.DOMAgent.setInspectModeEnabled')
https://bugs.webkit.org/show_bug.cgi?id=205148

Attachment 385469: Patch

https://bugs.webkit.org/attachment.cgi?id=385469&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 385469
  --> https://bugs.webkit.org/attachment.cgi?id=385469
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385469&action=review

r=me

> Source/WebInspectorUI/ChangeLog:22
> +	   * UserInterface/Base/Main.js:
> +	   Drive-by: remove duplicate function `WI._toggleInspectMode` as it
already exists.

!! How did a linter not catch this?


More information about the webkit-reviews mailing list