[webkit-reviews] review granted: [Bug 205147] FTL expects String.prototype to not qualify for StringObjectUse. : [Attachment 385465] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 205147: FTL expects String.prototype to not qualify for StringObjectUse.
https://bugs.webkit.org/show_bug.cgi?id=205147

Attachment 385465: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=385465&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 385465
  --> https://bugs.webkit.org/attachment.cgi?id=385465
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=385465&action=review

> Source/JavaScriptCore/ChangeLog:3
> +	   FTL expects String.prototype to not qualify for StringObjectUse.

it's not just the FTL. It's DFG+FTL

> Source/JavaScriptCore/runtime/JSType.h:120
> +    // Start StringObjectType types.

this seems unnecessary

> Source/JavaScriptCore/runtime/JSType.h:123
> +    // End StringObjectType types.

ditto

No need to call something out we don't rely on IMO