[webkit-reviews] review granted: [Bug 204823] Web Inspector: Error: Can't make a ContentView for an unknown representedObject of type: CallFrame : [Attachment 385436] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 204823: Web Inspector: Error: Can't make a ContentView for an unknown
representedObject of type: CallFrame
https://bugs.webkit.org/show_bug.cgi?id=204823

Attachment 385436: Patch

https://bugs.webkit.org/attachment.cgi?id=385436&action=review




--- Comment #10 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 385436
  --> https://bugs.webkit.org/attachment.cgi?id=385436
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385436&action=review

r=me, I'd still like to how how the GTK and Mac ports differ such that this can
happen, but I don't really see any harm in this fix as is, so I think it's fine
(with one change, and I apologize in advance)

> Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:704
> +	       if (!typeIdentifier || typeIdentifier !==
representedObject.constructor.TypeIdentifier)

I feel bad for saying this, but I think what you had before was actually
correct.  We don't want to return if the cookie doesn't have a
`WI.TypeIdentifierCookieKey` value, as many cookies don't have one.  It's
possible for the navigation sidebar to make it's own cookie that doesn't have
anything to do with a `representedObject` type, and as such, this code as is
would cause that to fail.  I apologize for making you go back and forth.
```
    if (matchTypeOnly)
	return !!typeIdentifier;
```