[webkit-reviews] review granted: [Bug 205122] Python 3: Add support in webkitpy.performance_tests : [Attachment 385404] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 11 12:43:19 PST 2019


Stephanie Lewis <slewis at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 205122: Python 3: Add support in webkitpy.performance_tests
https://bugs.webkit.org/show_bug.cgi?id=205122

Attachment 385404: Patch

https://bugs.webkit.org/attachment.cgi?id=385404&action=review




--- Comment #2 from Stephanie Lewis <slewis at apple.com> ---
Comment on attachment 385404
  --> https://bugs.webkit.org/attachment.cgi?id=385404
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385404&action=review

> Tools/Scripts/webkitpy/performance_tests/perftest.py:171
> +	   _log.info('median= {} {}, stdev= {} {}, min= {} {}, max= {}
{}'.format(

When there that many {} I prefer keywords. Makes it easier to read


More information about the webkit-reviews mailing list